Reorder checks in Walk to avoid panics#332
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Oct 13, 2015
Merged
Conversation
Contributor
|
This PR fixes the issues we were having with docker. |
LK4D4
force-pushed
the
fix_panic_in_getpids
branch
from
ffe2c98 to
77cf4da
Compare
Contributor
|
I am seeing some errors in other tests running locally |
Member
|
Same error locally |
Contributor
Author
|
Yup, I see. |
Also added test for host PID namespace Signed-off-by: Alexander Morozov <lk4d4@docker.com>
LK4D4
force-pushed
the
fix_panic_in_getpids
branch
from
77cf4da to
6c198ae
Compare
Contributor
Author
|
@mrunalp @crosbymichael fixed |
Contributor
|
okay tests are passing for me now. @tiborvass @ibuildthecloud. Do you guys want to try the updated patch as well? |
|
I'll try tonight |
|
@imikushin can you test this too? |
Contributor
|
@mrunalp this is basically blocking docker 1.9 so if someone could test/review/merge I would greatly appreciate it :) |
Member
|
LGTM |
Contributor
|
@tiborvass I am good with it from runc perspective ;) LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Oct 13, 2015
Reorder checks in Walk to avoid panics
Member
|
@tiborvass what is this docker u speak of? |
Contributor
|
Heh 😆 |
|
We applied this to docker 1.8 and it worked. Docker 1.9 blows up for us for different reasons, but this patch seems good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @tibor @ibuildthecloud